fix: add error handling to FindIsinByAliasIdAsync, use NullIfEmpty
This commit is contained in:
@@ -71,17 +71,24 @@ public class FundDataService : IFundDataService
|
||||
|
||||
public async Task<string?> FindIsinByAliasIdAsync(string aliasId)
|
||||
{
|
||||
await using var conn = new SqlConnection(_connectionString);
|
||||
await conn.OpenAsync();
|
||||
await using var cmd = new SqlCommand("rpt_FindIsinbyAliasID", conn)
|
||||
try
|
||||
{
|
||||
CommandType = CommandType.StoredProcedure
|
||||
};
|
||||
cmd.Parameters.AddWithValue("@AliasID", aliasId);
|
||||
await using var r = await cmd.ExecuteReaderAsync();
|
||||
if (!await r.ReadAsync()) return null;
|
||||
var isin = r.GetStringSafe("ISIN");
|
||||
return string.IsNullOrEmpty(isin) ? null : isin;
|
||||
await using var conn = new SqlConnection(_connectionString);
|
||||
await conn.OpenAsync();
|
||||
await using var cmd = new SqlCommand("rpt_FindIsinbyAliasID", conn)
|
||||
{
|
||||
CommandType = CommandType.StoredProcedure
|
||||
};
|
||||
cmd.Parameters.AddWithValue("@AliasID", aliasId);
|
||||
await using var r = await cmd.ExecuteReaderAsync();
|
||||
if (!await r.ReadAsync()) return null;
|
||||
return r.GetStringSafe("ISIN").NullIfEmpty();
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Errore FindIsinByAliasIdAsync per AliasID {AliasId}", aliasId);
|
||||
throw;
|
||||
}
|
||||
}
|
||||
|
||||
private static FundInfo MapFundInfo(SqlDataReader r) => new()
|
||||
|
||||
Reference in New Issue
Block a user